Skip to content

CSTACKEX-18: Cloudstack snapshot workflow for NFS3 protocol #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rajiv-jain-netapp wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CSTACKEX-18: Cloudstack snapshot workflow for NFS3 protocol #26

rajiv-jain-netapp wants to merge 4 commits into from

Conversation

@rajiv-jain-netapp
Copy link

@rajiv-jain-netapp rajiv-jain-netapp commented Jan 20, 2026 •
edited
Loading

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

suryag1201
suryag1201 reviewed Jan 29, 2026
View reviewed changes
...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

VolumeVO volumeVO = volumeDao.findById(volumeInfo.getId());
if(volumeVO == null) {
throw new CloudRuntimeException("takeSnapshot: VolumeVO not found for id: " + volumeInfo.getId());
Copy link

@suryag1201 suryag1201 Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suryag1201 suryag1201 suryag1201 left review comments

@sandeeplocharla sandeeplocharla Awaiting requested review from sandeeplocharla

@piyush5netapp piyush5netapp Awaiting requested review from piyush5netapp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rajiv-jain-netapp @suryag1201